Supported any names for MSGPACK_DEFINE_MAP using MSGPACK_NVP. #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
NVP stands for Name Value Pair or Name Variable Pair. |
nobu-k
reviewed
Nov 1, 2016
| d1.d = "ABC"; | ||
|
|
||
| msgpack::pack(sbuf, d1); | ||
| msgpack::object_handle oh = msgpack::unpack(sbuf.data(), sbuf.size()); |
Member
There was a problem hiding this comment.
We should probably check that each element has the right name here?
Contributor
Author
There was a problem hiding this comment.
Good point. If the converting logic have a bug that doing something wrong at packing and converting processes, it could be generate a right result.
I will update the test.
Member
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.