Skip to content

arm64: dts: qcom: msm8939-longcheer-l9100: add VCM for rear camera #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: wip/msm8916/v6.16-rc4
Choose a base branch
from

Conversation

a-andre
Copy link

@a-andre a-andre commented Jul 21, 2025

No description provided.

vknecht and others added 6 commits July 3, 2025 08:40
Some devices need writing values to VFE VBIF registers.
Add helper functions to do this.

Signed-off-by: Vincent Knecht <[email protected]>
The camera subsystem for the MSM8939 is the same as MSM8916 except with
3 CSID instead of 2, and some higher clock rates.

As a quirk, this SoC needs writing values to 2 VFE VBIF registers
(see downstream msm8939-camera.dtsi vbif-{regs,settings} properties).
This fixes black stripes across sensor and garbage in CSID TPG outputs.

Add support for the MSM8939 camera subsystem.

Signed-off-by: Vincent Knecht <[email protected]>
Add bindings for qcom,msm8939-camss in order to support the camera
subsystem for MSM8939.

Signed-off-by: Vincent Knecht <[email protected]>
Add the camera subsystem and CCI used to interface with cameras on the
Snapdragon 615.

Signed-off-by: Vincent Knecht <[email protected]>
CONFIG_VIDEO_IMX214=m

Signed-off-by: André Apitzsch <[email protected]>
Add rear camera support, using imx214 sensor.

Signed-off-by: André Apitzsch <[email protected]>
André Apitzsch and others added 9 commits July 26, 2025 12:04
# Describe the purpose of this series. The information you put here
# will be used by the project maintainer to make a decision whether
# your patches should be reviewed, and in what priority order. Please be
# very detailed and link to any relevant discussions or sites that the
# maintainer can review to better understand your proposed changes. If you
# only have a single patch in your series, the contents of the cover
# letter will be appended to the "under-the-cut" portion of the patch.

# Lines starting with # will be removed from the cover letter. You can
# use them to add notes or reminders to yourself. If you want to use
# markdown headers in your cover letter, start the line with ">#".

# You can add trailers to the cover letter. Any email addresses found in
# these trailers will be added to the addresses specified/generated
# during the b4 send stage. You can also run "b4 prep --auto-to-cc" to
# auto-populate the To: and Cc: trailers based on the code being
# modified.

Signed-off-by: André Apitzsch <[email protected]>

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
  "series": {
    "revision": 1,
    "change-id": "20250709-dw9719-8a8822efc1b1",
    "prefixes": []
  }
}
Document Dongwoon DW9719 and DW9761 VCM devicetree bindings.

Signed-off-by: André Apitzsch <[email protected]>
The name of property "dongwoon,vcm-freq" doesn't match its purpose.
Change the name of the property to "dongwoon,vcm-prescale" to better
describe its purpose and deprecate the old one.

Signed-off-by: André Apitzsch <[email protected]>
In preparation for adding models with different register sets, start
assigning the model based on the i2c match data.

Signed-off-by: Val Packett <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
The DW9718S is a similar part that uses a different register set but
follows the same method of operation otherwise. Add support for it
to the existing dw9719 driver.

Tested on the Moto E5 (motorola-nora) smartphone.

Signed-off-by: Val Packett <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
Update the close callback to match other similar drivers like dw9768.

Signed-off-by: Val Packett <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
Allow the dw9719 driver to be attached via FDT.

Signed-off-by: Val Packett <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
The "jiggle" code was not actually expecting failure, which it should
because that's what actually happens when the device wasn't already woken
up by the regulator power-on (i.e. in the case of a shared regulator).

Also, do actually enter the internal suspend mode on shutdown, to save
power in the case of a shared regulator.

Also, wait a bit longer (2x tOPR) on waking up, 1x is not enough at least
on the DW9718S as found on the motorola-nora smartphone.

Signed-off-by: Val Packett <[email protected]>
Signed-off-by: André Apitzsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants