Skip to content

feat (audience match types): Update audience evaluator and project config #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: rashid/audience-match-types-condition-evaluator
Choose a base branch
from

Conversation

rashidsp
Copy link
Collaborator

@rashidsp rashidsp commented Dec 10, 2018

Summary

This updates project config and the audience evaluator to finish the implementation of typed audience evaluation:

  • In audience_evaluator, allow evaluation to continue when no user attributes are passed (previously we were immediately returning false when no attributes were passed)
  • Update project_config to update audience_id_map with typed_audiences
  • Added unit tests checking that all top-level methods that accept user attributes can bucket users into experiments or rollouts that use typed audiences.

Test Plan

New & existing unit tests
Ran compatibility suite tests for typed audiences

@rashidsp rashidsp requested a review from oakbani December 10, 2018 15:56
@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 535

  • 79 of 79 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 532: 0.0%
Covered Lines: 3611
Relevant Lines: 3611

💛 - Coveralls

@rashidsp rashidsp changed the title feat (audience match types): Update audience evaluator and project co… feat (audience match types): Update audience evaluator and project config Dec 11, 2018
Copy link
Collaborator

@oakbani oakbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants