peripheral: add fifo size field for the relevant peripherals #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@i509VCB please check, this one is related to embassy-rs/embassy#4435 |
bespsm
force-pushed
the
peripheral-add-sys-fentries-field
branch
from
f21a2e2 to
c876463
Compare
i509VCB
reviewed
Aug 1, 2025
Member
i509VCB
left a comment
i509VCB
left a comment
There was a problem hiding this comment.
Looks good. Although I wonder if we should add a validation check to ensure all uart/spi/i2c instances have the attribute.
- The field name is 'sys_fentries' (it's borrowed from sysconfig) - The field value is different across chips and peripherals. - The field is relevant for I2C, SPI, UART peripherals, for the rest it has 'None' value - The filed type is usize
bespsm
force-pushed
the
peripheral-add-sys-fentries-field
branch
from
c876463 to
8925251
Compare
Contributor
Author
@i509VCB added validation check for SPI, UART and I2C |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.