-
Notifications
You must be signed in to change notification settings - Fork 143
Conversation
Sorry for the commit/travis spam 😅 |
@v1r0x Thanks for your contribution. Sorry for the delay. |
Thanks for merging it! 🎉 |
@v1r0x does this PR cover Migrations support? i.e. Schema Blueprints |
@spawn-guy Sorry, I think I don't understand your question. What do you want achive? |
@v1r0x i am referring to laravel database migrations and this (similar) piece of code
what do i need to use/pass-as-parameter to create a 3D point column? not a 2D point(as it does now) |
Good question. I think there should be no difference in storing 2D or 3D coordinates. $lat = 10;
$lon = 5;
$alt = 250;
$l = new \App\Location();
$l->location = new Point($lat, $lon, $alt);
$l->save(); |
@v1r0x yes i did ;) and, just to verify, i did it again just now
|
I think I only tested it with Sorry for the confusion. It's been a long time working with that code here 😉 |
@v1r0x yeah. that PR seems to do a similar thing for |
Fix #18
I (hopefully) added a third dimension as optional paramter to all neccessary constructors/create functions. In functions that return the content have a 3d check as well.
The 3d check is implemented as
is3d()
which does a simple check on the first element in the geometry (e.g. first LineString in Polygon or first Polygon in MultiPolygon, ...). I don't know if there is a better check. Any idea/suggestion is much appreciated :)cc @njbarrett