This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix coordinate precision #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructor reads value from config/postgis.php:precision or defaults to 6 (the default precision for sprintf). It is not anticipated that users will want to customise precision for an individual point, so no argument has been added to the constructor signature. A setter is provided for precision, though this is primarily to enable tests. If users do need to set precision for an individual point, the setter may be used. stringifyFloat has been converted to dynamic function to ease testing. It was only ever called from a non-static context anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address Coordinate precision lost #167
Constructor reads value from config or defaults to 6 (the default precision for sprintf). It is not anticipated that users will want to customise precision for an individual point, so no argument has been added to the constructor signature.
A setter is provided for the precision property, though this is primarily to enable tests. If users do need to set precision for an individual point, the setter may be used.
stringifyFloat has been converted to dynamic function to ease testing. It was only ever called from a non-static context anyway.
Added tests, default config and updated readme