Installation error on MacOS

[Daniil-Gusev]

Running the install.sh script after installing the tools using vsdownload.py fails with the following message:
mv: cannot move 'HostX64' to a subdirectory of itself, 'Hostx64/HostX64'.
I suspect the issue is related to the case-insensitive nature of the macOS file system.

[mstorsjo]

This sounds odd; we do test it in CI, installed on macOS (presumably on a case insensitive file system, as we've had to deal with case issues before, with fixes like in 0110cd7, before adding macOS CI in c64b8f9).

Are you trying to rerun an install in a directory with a previous install (or continue from a failed install)?

[Daniil-Gusev]

I clone the repository, first run the vsdownload.py script, and then install.sh.
From line 88 onward in install.sh, you'll find the following:

if [ -d HostX64 ]; then
    # 15.x - 16.4
    mv HostX64 Hostx64
fi
if [ -d HostARM64 ]; then
    # 17.2 - 17.3
    mv HostARM64 Hostarm64
fi
if [ -d HostArm64 ]; then
    # 17.4
    mv HostArm64 Hostarm64
fi
if [ -d Hostarm64/ARM64 ]; then
    # 17.2 - 17.3
    mv Hostarm64/ARM64 Hostarm64/arm64
fi

In a case-insensitive file system, HostX64 and Hostx64 are the same, which is, I believe, what causes the error. When I comment out this block of code, the script runs without errors and completes successfully.

[mstorsjo]

In a case-insensitive file system, HostX64 and Hostx64 are the same, which is, I believe, what causes the error. When I comment out this block of code, the script runs without errors and completes successfully.

Hmm, this is odd. So if this part of the shell script indeed causes problems for you, I wonder why that is.

To study the behaviour, I tried doing this:

$ mkdir HostX64
$ ls -ld Host*
drwxr-xr-x  2 martin  staff  64 Jan  7 00:25 HostX64
$ [ -d HostX64 ] && echo HostX64 exists
HostX64 exists
$ [ -d Hostx64 ] && echo Hostx64 exists
Hostx64 exists
$ mv HostX64 Hostx64
$ ls -ld Host*
drwxr-xr-x  2 martin  staff  64 Jan  7 00:25 Hostx64
$ rmdir Hostx64

So at least on my system, I can do mv HostX64 Hostx64 just fine, without errors, even though both names refer to the same directory. (And doing it does change the canonical capitalization of that directory entry.)

Does this sequence of commands work the same for you, or does the mv cause a failure for you in this setup as well?

[Daniil-Gusev]

The issue is indeed on my side, I apologize for wasting your time. The thing is actually this:

mac-mini:~ daniilgusev$ mkdir HostX64
mac-mini:~ daniilgusev$ [ -d HostX64 ] && echo HostX64 exists
HostX64 exists
mac-mini:~ daniilgusev$ [ -d Hostx64 ] && echo Hostx64 exists
Hostx64 exists
mac-mini:~ daniilgusev$ mv HostX64 Hostx64
mv: cannot move 'HostX64' to a subdirectory of itself, 'Hostx64/HostX64'
mac-mini:~ daniilgusev$ which mv
/opt/homebrew/opt/coreutils/libexec/gnubin/mv
mac-mini:~ daniilgusev$ /bin/mv HostX64 Hostx64
mac-mini:~ daniilgusev$ rmdir Hostx64
mac-mini:~ daniilgusev$ 

Could we do something like this at the beginning of the script:

MV=$(env -i PATH="/usr/bin:/bin:/usr/sbin:/sbin" /bin/sh -c "which mv")

and then use $MV explicitly everywhere instead of just mv?