Don't abort when run on Linux / Mac OS.

[iamFIREcracker]

I am trying to call this action from another composite action, one that
is supposed to be working for Linux, Mac OS, and Windows.

Ideally one would put the uses statement behind a conditional
expression, like:

- uses: msys2/setup-msys2@v2
  if: runner.os == 'Windows'

However, composite actions do not support conditional steps yet (see:
actions/runner#834), so the only way to keep
the setup-msys2 step inside my action (and not forcing the wokflow to
use it instead), is to suppress the error message (It's OK to log it,
but it should not fail).

[eine]

I understand the use case, but I don't think it's desirable to change the default behaviour. It is a legit error to use this action on an environment other than Windows, because MSYS2 is not supported anywhere else. Therefore, please, add an option to the Action for users who want the proposed behaviour to enable it explicitly. E.g. platform-check-severity. That option is pretty specific, and we can remove it in the future when composite actions support conditionals.

[iamFIREcracker]

I understand the use case, but I don't think it's desirable to change the default behaviour. It is a legit error to use this action on an environment other than Windows, because MSYS2 is not supported anywhere else.

I did not realize other actions might be relying on this one to error out in case the workflow was running on Linux, or Mac OS. My bad!

Therefore, please, add an option to the Action for users who want the proposed behaviour to enable it explicitly. E.g. platform-check-severity. That option is pretty specific, and we can remove it in the future when composite actions support conditionals.

Added platform-check-severity as suggested (supported values: fatal, to abort the execution, and warn to log and move on).

I even added a test, which will soon tell us if I did something wrong or not.

M.

[eine]

Thanks @iamFIREcracker!

[iamFIREcracker]

Oh boy, in the rush I did not realize I had placed fail-fast inside matrix and not strategy...thanks for fixing this on my behalf!

[iamFIREcracker]

Question: when is the next release scheduled for?

(I will be keep on using my fork for the time being, so there is no rush, really)

[eine]

Oh boy, in the rush I did not realize I had placed fail-fast inside matrix and not strategy...thanks for fixing this on my behalf!

It was my bad! I wrote the snippet incorrectly, so you were maybe mislead by that. Then, I fixed my comment, and the code 😉.

Question: when is the next release scheduled for?

ASAP. I'm waiting to see if #166 can make it into this release (depending on merging msys2/MSYS2-packages#2676).

[eine]

@iamFIREcracker, msys2/MSYS2-packages#2676 was merged already, and the package is pending signing for uploading: https://packages.msys2.org/queue. As soon as r54.fa231e8-1 is available upstream, I'll publish v2.6.0.

[eine]

@iamFIREcracker I just published v2.6.0 and updated tag v2 accordingly.