Call process.exit() at the end to avoid node waiting#354
Merged
lazka merged 1 commit intomsys2:mainfrom Jan 6, 2024
Merged
Conversation
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing. See actions/toolkit#1578 for the upstream issue. Work around by forcing node to exit. Fixes msys2#346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the update to node20, in case we would call the GH cache upload functions the process would not exit right away, but stay around for 1-2 minutes doing nothing.
See actions/toolkit#1578 for the upstream issue.
Work around by forcing node to exit.
Fixes #346