Skip to content

cache: conditionally disable the install cache, unset by default#63

Merged
eine merged 1 commit intomsys2:masterfrom
lazka:disable-cache-again
Aug 14, 2020
Merged

cache: conditionally disable the install cache, unset by default#63
eine merged 1 commit intomsys2:masterfrom
lazka:disable-cache-again

Conversation

@lazka
Copy link
Copy Markdown
Member

@lazka lazka commented Aug 14, 2020

For some reason it sometimes loses files. It's not clear where the error
is, so let's disable for now.

Fixes #61

For some reason it sometimes loses files. It's not clear where the error
is, so let's disable for now.

Fixes msys2#61
@lazka
Copy link
Copy Markdown
Member Author

lazka commented Aug 14, 2020

Alternatively we could check if all files are there at some point to pin down where the error happens.

@eine
Copy link
Copy Markdown
Collaborator

eine commented Aug 14, 2020

I think this PR is ok as a temporal solution. The logic is not removed, but just conditionally disabled.

Anyway, I believe it might be worth reporting this to GitHub. Maybe we can enhance our logic to track down when is it happening. But they might be able to detect it in their infrastructure too.

@eine eine changed the title Disable the install cache again cache: conditionally disable the install cache, unset by default Aug 14, 2020
@eine eine merged commit 434d91b into msys2:master Aug 14, 2020
@lazka
Copy link
Copy Markdown
Member Author

lazka commented Aug 14, 2020

I can't really rule out that the problem isn't on our side, even though I don't know what it could be.

@eine
Copy link
Copy Markdown
Collaborator

eine commented Aug 14, 2020

Is the error consistent? I mean, is it fixed by restarting a job?

@lazka
Copy link
Copy Markdown
Member Author

lazka commented Aug 14, 2020

I haven't restarted the same job, but followup commits failed as well I think.

@lazka
Copy link
Copy Markdown
Member Author

lazka commented Aug 14, 2020

The above two jobs show it perfectly (ctrl+f the cache IDs in them). Either it didn't save the files properly, or didn't restore it properly, or any of our commands after the restore removed it (but in this case there was no update, so this should in theory be a noop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lost files in the cache

2 participants