Poetry 2.0 compatibility

[dalito]

Today poetry 2.0 came out and it seems that your plugin does not yet work with PEP-621 pyproject.toml where for example the project name is in the [project] section.

[project]
# Storing project metadata in pyproject.toml 
name = "mything"

I get an unbound local error with poetry-dynamic-versioning version 1.4.1:

 UnboundLocalError

  cannot access local variable 'name' where it is not associated with a value

  at ~\.local\pipx\venvs\poetry\Lib\site-packages\poetry_dynamic_versioning\__init__.py:668 in _get_and_apply_version
      664│         name = pyproject["project"]["name"]
      665│         original = pyproject["project"].get("version")
      666│         dynamic_index = pyproject["project"]["dynamic"].index("version")
      667│     else:
    → 668│         return name if name in _state.projects else None
      669│
      670│     if name in _state.projects:
      671│         return name
      672│

[edgarrmondragon]

@dalito how did you declare the version?

[mtkennerly]

Hi! The plugin does support PEP-621 (at least based on a pre-release version of Poetry - I'll re-test with 2.0), but your pyproject.toml must:

• not define tool.poetry.name
• define project.name
• define project.dynamic to include "version"
• not define project.version

[rayrapetyan]

There is a more general incompatibility issue:

Because no versions of poetry-dynamic-versioning match >1.4.1,<2.0.0
 and poetry-dynamic-versioning[plugin] (1.4.1) depends on poetry (>=1.2.0,<2.0.0), poetry-dynamic-versioning[plugin] (>=1.4.1,<2.0.0) requires poetry (>=1.2.0,<2.0.0).
So, because poetry-instance depends on both poetry (2.0.0) and poetry-dynamic-versioning[plugin] (^1.4.1), version solving failed.

Hardcoding 1.x version solves the issue:

curl -sSL https://install.python-poetry.org | POETRY_VERSION=1.8.5 python3 -

[dalito]

I added poetry-dynamic-versioning to poetry 2.0.0 by injecting it with pipx.

First, I still had a version under [project]. Once I replaced this by dynamic = ["version"], poetry check starts complaining about the missing version instead of the missing name:

The Poetry configuration is invalid:
- Either [project.version] or [tool.poetry.version] is required in package mode.

My pyproject.toml is here: https://github.com/nfdi4cat/pid4cat-model/pull/36/files - @mtkennerly I think it matches the points you listed above.

[dalito]

If I add a version under tool.poetry,

[tool.poetry]
requires-poetry = ">=2.0"
version = "0.0.0"

poetry checks passes but gives a warning

Warning: [project.version] and [tool.poetry.version] are both set. The latter will be ignored.
If you want to set the version dynamically via `poetry build --local-version` or you are using a plugin, which sets the version dynamically, you should define the version in [tool.poetry] and add 'version' to [project.dynamic].

It still a bit confusing. Which config would work without warning?

[mtkennerly]

@rayrapetyan

poetry-dynamic-versioning[plugin] (1.4.1) depends on poetry (>=1.2.0,<2.0.0), poetry-dynamic-versioning[plugin] (>=1.4.1,<2.0.0) requires poetry (>=1.2.0,<2.0.0).

Thanks for bringing that up. The master branch already uses poetry = ">=1.2.0", which should fix that, but the latest release still uses poetry = "^1.2.0".

@dalito

Warning: [project.version] and [tool.poetry.version] are both set. The latter will be ignored. If you want to set the version dynamically via `poetry build --local-version` or you are using a plugin, which sets the version dynamically, you should define the version in [tool.poetry] and add 'version' to [project.dynamic].

Looks like this changed since the beta versions of 2.0. I'll need to update the plugin to account for this logic 👍