Skip to content

*: Upstream changes from proglottis/gpgme#2

Closed
wking wants to merge 4 commits into
mtrmac:masterfrom
wking:upstream-changes
Closed

*: Upstream changes from proglottis/gpgme#2
wking wants to merge 4 commits into
mtrmac:masterfrom
wking:upstream-changes

Conversation

@wking

@wking wking commented Mar 9, 2019

Copy link
Copy Markdown

Pulling in upstrem improvements. Generated with:

$ git remote add proglottis git://github.com/proglottis/gpgme.git
$ git fetch proglottis
$ git remote add mtrmac git://github.com/mtrmac/gpgme.git
$ git fetch mtrmac
$ git checkout -b upstream-changes proglottis/master
$ git merge --log mtrmac/master
$ git checkout --ours gpgme.go
$ git add gpgme.go
$ git commit

@wking
wking force-pushed the upstream-changes branch from c32cad8 to f464b3f Compare March 9, 2019 07:27
Generated with:

  $ git remote add proglottis git://github.com/proglottis/gpgme.git
  $ git fetch proglottis
  $ git remote add mtrmac git://github.com/mtrmac/gpgme.git
  $ git fetch mtrmac
  $ git	checkout -b upstream-changes proglottis/master
  $ git merge --log mtrmac/master
  $ emacs gpgme.go  # mostly keep proglottis, but keep mtrmac's 'Unavailable in 1.3.2' comments
  $ git add gpgme.go
  $ git commit

* mtrmac/master:
  Comment out a few constants to make this build with gpgme 1.3.2
  Comment out a few constants to make this build with gpgme 1.4.3
@wking
wking force-pushed the upstream-changes branch from f464b3f to c94c997 Compare March 9, 2019 07:29
@wking

wking commented Mar 9, 2019

Copy link
Copy Markdown
Author
$ git checkout --ours gpgme.go

I've pushed c32cad8 -> c94c997 backing off of the above to keep our Unavailable in 1.3.2 comments.

@mtrmac

mtrmac commented Mar 11, 2019

Copy link
Copy Markdown
Owner

Yes, something like this should eventually happen (or maybe I should just rebase the branches), but not right now please; I’m in the middle of (as time permits) debugging those crashes you’ve seen as well, and a moving target would not help.

I have reviewed those commits some time ago, and nothing in them matters to the c/image use AFAICT.

@mtrmac

mtrmac commented Jan 18, 2020

Copy link
Copy Markdown
Owner

This repo was just updated to fix proglottis#23 (finally fixing the crashes, thanks to Ulrich Obergfell, which brings it up to date with 0.1.1.

@mtrmac mtrmac closed this Jan 18, 2020
@wking
wking deleted the upstream-changes branch January 18, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants