Move the start of the server to only run when the microservice runs #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the server start from importing from mu and moves it, so it only runs when the microservice is started
Motivation
Until now whenever you imported from the mu library you started a server, which was fine for simpler microservices, where everything is imported on app.js, but as the microservices get more complex we need to do some imports without the server starting, for example in order to do unit tests of functions using the sparql helpers.
Also imho it's conceptually wrong that a import has a side effect.
Testing
Check that everything works as before, and the PR doesn't break a microservice in anyway. Now you should be able to import from mu without starting any server