fix: Failed to download checksums.txt when using launch to install localai#7788
Merged
mudler merged 3 commits intomudler:masterfrom Dec 30, 2025
Conversation
- Add HTTP client with 30s timeout to ReleaseManager - Implement downloadFileWithRetry with 3 attempts and exponential backoff - Allow manual checksum placement at ~/.localai/checksums/checksums-<version>.txt - Continue installation with warning if checksum download/verification fails - Add test for HTTPClient initialization - Fix linter error in systray_manager.go Fixes mudler#7385 Signed-off-by: majiayu000 <1835304752@qq.com>
This commit addresses issue mudler#7385 by implementing: - Retry logic (3 attempts) for checksum file downloads - Fallback to manually placed checksum files - Option to proceed with installation if checksums unavailable (with warnings) - Fixed resource leaks in download retry loop - Added configurable HTTP client with 30s timeout The installation will now be more resilient to network issues while maintaining security through checksum verification when available. Signed-off-by: majiayu000 <1835304752@qq.com>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
reviewed
Dec 30, 2025
| log.Printf("Warning: failed to download checksums: %v", downloadErr) | ||
|
|
||
| // Check if user has manually placed a checksums file | ||
| manualChecksumPath := filepath.Join(rm.ChecksumsPath, fmt.Sprintf("checksums-%s.txt", version)) |
Owner
There was a problem hiding this comment.
would actually make sense here to check if first there is already a checksum file and honor that, and skipping download entirely in such case
This commit addresses the review feedback from mudler on PR mudler#7788. The code now checks if there's already a checksum file (either manually placed or previously downloaded) and honors that, skipping download entirely in such case. Changes: - Check for existing checksum file at ~/.localai/checksums/checksums-<version>.txt first - Check for existing downloaded checksum file at binary path - Only attempt to download if no existing checksum file is found - This prevents unnecessary network requests and honors user-placed checksums Signed-off-by: majiayu000 <1835304752@qq.com> 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mudler
pushed a commit
to coffeerunhobby/LocalAI
that referenced
this pull request
Jan 2, 2026
…calai (mudler#7788) * fix: add retry logic and fallback for checksums.txt download - Add HTTP client with 30s timeout to ReleaseManager - Implement downloadFileWithRetry with 3 attempts and exponential backoff - Allow manual checksum placement at ~/.localai/checksums/checksums-<version>.txt - Continue installation with warning if checksum download/verification fails - Add test for HTTPClient initialization - Fix linter error in systray_manager.go Fixes mudler#7385 Signed-off-by: majiayu000 <1835304752@qq.com> * fix: add retry logic and improve checksums.txt download handling This commit addresses issue mudler#7385 by implementing: - Retry logic (3 attempts) for checksum file downloads - Fallback to manually placed checksum files - Option to proceed with installation if checksums unavailable (with warnings) - Fixed resource leaks in download retry loop - Added configurable HTTP client with 30s timeout The installation will now be more resilient to network issues while maintaining security through checksum verification when available. Signed-off-by: majiayu000 <1835304752@qq.com> * fix: check for existing checksum file before downloading This commit addresses the review feedback from mudler on PR mudler#7788. The code now checks if there's already a checksum file (either manually placed or previously downloaded) and honors that, skipping download entirely in such case. Changes: - Check for existing checksum file at ~/.localai/checksums/checksums-<version>.txt first - Check for existing downloaded checksum file at binary path - Only attempt to download if no existing checksum file is found - This prevents unnecessary network requests and honors user-placed checksums Signed-off-by: majiayu000 <1835304752@qq.com> 🤖 Generated with Claude Code Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Signed-off-by: majiayu000 <1835304752@qq.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #7385
Changes
~/.localai/checksums/checksums-<version>.txtTesting
Generated with Claude Code