fix(llama.cpp/mmproj): fix loading mmproj in nested sub-dirs different from model path#7832
Merged
fix(llama.cpp/mmproj): fix loading mmproj in nested sub-dirs different from model path#7832
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mudler
changed the title
mudler
changed the title
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Construct the mmproj path from the golang side of things (which makes it more stable and predictable, and doesn't require backend rebuild)
Problem: when importing LocalAI puts mmproj files of llama.cpp in llama-cpp/mmproj, and models in llama-cpp/models. However, this doesn't work as expected because we assume that mmproj files are in the same paths of the model file.
This PR makes sure we join the path with the model path as expected (top-level).
Notes for Reviewers
Signed commits