Wrong typings for makeStyles

[bartekczyz]

• This is not a v0.x issue.
• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

It should compile without errors

Current Behavior

I'm getting Type error: Expected 1 arguments, but got 2. TS2554 when using makeStyles with 2nd argument

Tech	Version
@material-ui/core	v3.6.0
@material-ui/styles	v3.0.0-alpha.1
React	v.16.7.0-alpha.2
TypeScript	v3.1.6

[eps1lon]

Could you please add the snipped of your usage? Just to verify the options shape.

[bartekczyz]

Sure,

makeStyles(styles); // works
makeStyles(styles, {});  // doesn't work

It should accept 2nd argument (https://github.com/mui-org/material-ui/blob/next/packages/material-ui-styles/src/makeStyles.js#L14) but it doesn't (https://github.com/mui-org/material-ui/blob/next/packages/material-ui-styles/src/index.d.ts#L113)

[eps1lon]

Oh come on. I meant your actual usage which I could add to the test. You're obviously not just adding an empty object.

[bartekczyz]

This is NOT about the shape of options argument, but the fact that it's passed to the function. Try to pass an empty object and it will fail. If you want real usage, here it is

makeStyles(styles, {name: 'test'});

[eps1lon]

I just wanted to make sure that everything is covered. I didn't intend to make this sound like I'm somehow not believing you that this is an actualyl issue. Just wanted to make sure to make this right. I'm sure you wouldn't have been satisfied if I just added options?: {}.

[bartekczyz]

It would be great to have options typed. However, all I wanted to say is that typings are not covering the code and it's impossible to pass any option using typescript.