[Icon Menu] Support for closeAfterTap.#1124
Closed
mkucharz wants to merge 16 commits intomui:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
Thanks @mkucharz - I think we should call the new prop closeOnItemTouchTap
Contributor
Author
|
@hai-cea How it looks right now? |
Member
|
@mkucharz I think it looks good. Not sure why the build is showing errors. Maybe you need to rebase? |
Member
|
Thanks @mkucharz - Can you squash this down to 1 commit please? |
This improve a nice bit of performence when menu scroll.
…-ui into icon-menu-closeAfterTap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually we want to close menu after click, but not always (e.g. when menu item is a checkbox).