[Tabs] optimization of tabs for static label elements#11703
Closed
toddtarsi wants to merge 11 commits intomui:masterfrom
Closed
[Tabs] optimization of tabs for static label elements#11703toddtarsi wants to merge 11 commits intomui:masterfrom
toddtarsi wants to merge 11 commits intomui:masterfrom
Conversation
added 5 commits
June 4, 2018 09:54
Author
|
@oliviertassinari - Okay, I have the first pass of this done. I have a question for you: If I'd like to bundle my fork and import and use it to a node dependency to test it, how would I do this? My plan is to fork this branch and test it on my codebase as a dependency. This would help me sanity test that this works as expected on mobile where resizing doesn't really occur. |
Author
|
Actually, I am testing this now and it needs a bit more fixing. Have created an onsite demo to test it. Will report when its 100%. |
Author
|
Alright, the scrollbar handles the value changes as expected now. Everything here works well by my testing using the new demo I created at the bottom of the Tabs page. |
Member
|
@toddtarsi I'm moving the conversation back to #11673. |
This was referenced Nov 17, 2020
This was referenced Dec 1, 2020
This was referenced Jun 24, 2023
This was referenced Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a wip implementation of #11673.
I'll be able to finish this out and put together a benchmark test with some tabs later this week, but for now I have to look at something else. Thanks again for the great repo!
Currently this does the following:
Tabsees staticLabel, it currently avoids calling checkTextWrap after mounting.This is what I'm still working on:
Tabssees staticLabel, it will avoid the calls for tabsMeta after mounting, and only update tabMeta when value changes.Thanks again for the great repo!