Skip to content

[Grow] Condense the demo#13665

Merged
oliviertassinari merged 2 commits intomui:masterfrom
willigarneau:patch-2
Nov 21, 2018
Merged

[Grow] Condense the demo#13665
oliviertassinari merged 2 commits intomui:masterfrom
willigarneau:patch-2

Conversation

@willigarneau
Copy link
Copy Markdown
Contributor

@willigarneau willigarneau commented Nov 21, 2018

We could just use the component's timeout props. :)

We could just use the component's timeout props. Tried it myself and it worked :)
@willigarneau willigarneau changed the title Timeout props [Grow]Timeout props Nov 21, 2018
@oliviertassinari
Copy link
Copy Markdown
Member

conditionally applies the timeout property to change the entry speed.

@Thyix This changes the documentation description behavior. What's the motivation?

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. component: Grow labels Nov 21, 2018
@willigarneau
Copy link
Copy Markdown
Contributor Author

I was just using it, and wondered if you could use timeout props without adding a condition after the in props. After seeing that it worked, I thought it could be a nice fix for the future users :)

@oliviertassinari oliviertassinari changed the title [Grow]Timeout props [Grow] Condense the demo Nov 21, 2018
@oliviertassinari
Copy link
Copy Markdown
Member

@Thyix Ok thanks, your use case is valid but change what we want to demonstrate. I have added a comment in this pull request diff.

@oliviertassinari oliviertassinari merged commit 086a6a5 into mui:master Nov 21, 2018
const { classes } = this.props;
const { checked } = this.state;

const polygon = (
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps not the best choice of variable name...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

child?

@oliviertassinari oliviertassinari added scope: transitions Changes related to the transitions. and removed component: Grow labels Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: transitions Changes related to the transitions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants