Skip to content

[docs] Add support for changing react version in codesandbox demos#13686

Merged
oliviertassinari merged 3 commits intomui:masterfrom
joshwooding:support-next-in-demos
Nov 26, 2018
Merged

[docs] Add support for changing react version in codesandbox demos#13686
oliviertassinari merged 3 commits intomui:masterfrom
joshwooding:support-next-in-demos

Conversation

@joshwooding
Copy link
Copy Markdown
Collaborator

  • I have followed (at least) the PR section of the contributing guide.

  • [docs] Add support for changing react version in codesandbox demos

  • [docs] Change styles Hook API codesandbox to use next version of react and react-dom

Fixes #13680

Not sure if the demoOptions key should be react or reactVersion

@joshwooding joshwooding force-pushed the support-next-in-demos branch from 7c8f0e1 to 823555e Compare November 24, 2018 21:42
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Nov 26, 2018
@oliviertassinari oliviertassinari merged commit f78ac87 into mui:master Nov 26, 2018
@oliviertassinari
Copy link
Copy Markdown
Member

@joshwooding Thank you :)

@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented Nov 27, 2018

Not sure if the demoOptions key should be react or reactVersion

I went with the shortest version. It's also closer to what people have in their package.json.

@joshwooding joshwooding deleted the support-next-in-demos branch November 27, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants