[InputBase] Remove dead disableUnderline property

[PierreCapo]

• I have followed (at least) the PR section of the contributing guide.

[eps1lon]

It looks like this class key is not used in InputBase. Could you add a link to the documentation where this class key is documented or a codesnippet how you use this class key?

[oliviertassinari]

This style rule doesn't exist. Something is wrong.

[PierreCapo]

Hello guys, sorry for not letting a note on my PR, I had to go fast. The issue I'm facing is that when i do :

const styles = {
  root: {
    color: "white",
  },
  icon: {
    fill: "white"
  }
};

<Select
    inputProps={{
    classes: {
         root: classes.root
          icon: classes.icon
     }
    }}>
</Select>

I got a typescript error upon icon which basically says that the key is not specified in the this class.

With the PR I made it fixes the problem, but after reading your comments I understand that I haven't provided the good solution. Instead, it seems that there is a SelectClassKey in the Select.d.ts file which should be used for typing this part of the code, but instead it just uses the regular InputBaseClassKey. I'm going to look why and update the PR when I find the solution.

[oliviertassinari]

@PierreCapo Let me guide you through it. The class name you want to target is:

The component is Select and the style rule is icon so, it should be:

const styles = {
  icon: {
    fill: "white"
  }
};

<Select classes={{ icon: classes.icon }} />

---

I'm updating the pull request to remove the dead disableUnderline typescript property.

updated

[PierreCapo]

Thanks @oliviertassinari for your comment, I understand better how the styling works now 👍