[Textarea] Refactor the implementation #15331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
type: bug
oliviertassinari
force-pushed
the
Textarea
branch
from
c2d91ab to
206988b
Compare
|
@material-ui/core: parsed: -0.36% 😍, gzip: +0.10% Details of bundle changes.Comparing: 6891704...415ec90
|
oliviertassinari
force-pushed
the
Textarea
branch
2 times, most recently
from
a696dad to
dcf6ca2
Compare
oliviertassinari
force-pushed
the
Textarea
branch
from
dcf6ca2 to
64cd672
Compare
oliviertassinari
force-pushed
the
Textarea
branch
4 times, most recently
from
79e0c83 to
4d09a2e
Compare
eps1lon
previously requested changes
Apr 13, 2019
joshwooding
reviewed
Apr 14, 2019
eps1lon
reviewed
Apr 14, 2019
oliviertassinari
force-pushed
the
Textarea
branch
from
4d09a2e to
0360518
Compare
Member
Author
|
Thanks for the reviews, I have tried to take them all into account. |
Member
Author
|
I have tried to replace the 2 textareas with a single one. It seems to work perfectly 👌💎. |
Before: @material-ui/core: parsed: -0.34% 😍, gzip: -0.20% 😍 @material-ui/core/Textarea +Infinity% 🔺 +Infinity% 🔺 0 6,750 0 2,669
This reverts commit 4d09a2e.
oliviertassinari
force-pushed
the
Textarea
branch
from
313895e to
415ec90
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes In Multiline textField scroll appear when number of line is less then maxRows #9277
Closes TextField multiline adds extra height #15286
Closes multiline InputBase is showing scrollbar when font is changed to Open Sans #15007
Closes [Input] display issues #13357
Closes [TextField (multiline, controlled)] In IE and Edge, a controlled multiline TextField doesn't expand upon adding newlines with no other text present. #12172
Closes [Textfield] Multiline Textfield is larger than expected #11740
Closes Enhancement on Textarea.js to allow custom ROWS_HEIGHT value #11375
@material-ui/core: parsed: -0.31% 😍I think that we should make this component public in v4+.