Skip to content

[TextField] Pass rowsMin prop to underlying abstractions #15411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 19, 2019
Merged

[TextField] Pass rowsMin prop to underlying abstractions #15411

merged 4 commits into from
Apr 19, 2019

Conversation

pachuka
Copy link
Contributor

@pachuka pachuka commented Apr 19, 2019

Updates to resolve #15407

pachuka added 3 commits April 18, 2019 22:04
@pachuka
Added rowsMin prop on components that are abstractions of the TextFie…
c0b709b 
…ld component and updated relevant typescript types.
@pachuka
Updated TextField demos with an example where minRows = 2 and maxRows…
a597a8b 
… = infinity. (Starts at fixed height, then grows as user enters more text).
@pachuka
Updated docs
1225625
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 19, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 1bff0f7...da9c038

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.02% 🔺 311,951 311,983 84,271 84,286
@material-ui/core/Paper 0.00% 0.00% 67,279 67,279 19,963 19,963
@material-ui/core/Paper.esm 0.00% 0.00% 60,640 60,640 18,883 18,883
@material-ui/core/Popper 0.00% 0.00% 34,907 34,907 11,809 11,809
@material-ui/core/Textarea 0.00% 0.00% 5,327 5,327 2,291 2,291
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,771 5,771
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 973 973
@material-ui/lab 0.00% 0.00% 141,612 141,612 42,721 42,721
@material-ui/styles 0.00% 0.00% 50,833 50,833 15,012 15,012
@material-ui/system 0.00% 0.00% 11,765 11,765 3,929 3,929
Button 0.00% 0.00% 85,621 85,621 25,584 25,584
Modal 0.00% 0.00% 79,901 79,901 24,015 24,015
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main 0.00% 0.00% 647,735 647,735 201,782 201,782
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.02% 🔺 293,250 293,282 82,317 82,330

Generated by 🚫 dangerJS against da9c038

@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! new feature New feature or request labels Apr 19, 2019
@oliviertassinari
Copy link
Member

I have removed the new demos as we already have too much of them. We already have a visual regression test for this feature, it should be enough. Thank you for updating the TypeScript definitions too :).

@oliviertassinari oliviertassinari merged commit f132c3c into mui:next Apr 19, 2019
@oliviertassinari
Copy link
Member

@pachuka It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@pachuka
Copy link
Contributor Author

pachuka commented Apr 19, 2019

@oliviertassinari, thanks! Glad I could help.

@pachuka pachuka deleted the bugfix/text-field-rowsMin-prop branch April 19, 2019 16:36
@pachuka pachuka mentioned this pull request Apr 21, 2019
Merged
1 task
oliviertassinari pushed a commit that referenced this pull request Apr 22, 2019
@pachuka @oliviertassinari
[Textarea] Remove rowsMin prop (#15430)
69466d8 
* Revert "[TextField] Pass rowsMin prop to underlying abstractions (#15411)"

This reverts commit f132c3c.

* Removed rowsMin prop.

* Reverted mistakenly removed logic.

* explicit that  is the minimum number of rows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Textarea] Remove rowsMin, use the rows prop instead
3 participants
@pachuka @mui-pr-bot @oliviertassinari