[styles] Name anonymous function type #19996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to speed up compilation (by simplifying structural type comparison). Note that, in most cases, the performance benefit of extracting a name type will be insignificant.
Contributor
Author
|
Helps with #19113. |
|
No bundle size changes comparing daa0eff...82b8833 |
eps1lon
added
scope: styles
eps1lon
changed the title
Contributor
Author
|
Thanks @eps1lon! |
Member
|
@amcasey Much appreciated, thanks. The |
This was referenced Mar 20, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to speed up compilation (by simplifying structural type comparison). Note that, in most cases, the performance benefit of extracting a name type will be insignificant.
In this case, however, it appears to cut compilation time by 10-15%.
Change courtesy of @ahejlsberg.