Skip to content

[Autocomplete] Correct example of virtualization #20496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 2 commits into from
Apr 11, 2020
Merged

[Autocomplete] Correct example of virtualization #20496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac72caf
issue #20399 Correct example of virtualize autocomplete
gnazarova Apr 11, 2020
c9dca03
fix height out-of-sync
oliviertassinari Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion docs/src/pages/components/autocomplete/Virtualize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ const OuterElementType = React.forwardRef((props, ref) => {
return <div ref={ref} {...props} {...outerProps} />;
});

function useResetCache(data) {
const ref = React.useRef(null);
React.useEffect(() => {
if (ref.current != null) {
ref.current.resetAfterIndex(0, true);
}
}, [data]);
return ref;
}

// Adapter for react-window
const ListboxComponent = React.forwardRef(function ListboxComponent(props, ref) {
const { children, ...other } = props;
Expand All @@ -51,14 +61,16 @@ const ListboxComponent = React.forwardRef(function ListboxComponent(props, ref)
return itemData.map(getChildSize).reduce((a, b) => a + b, 0);
};

const gridRef = useResetCache(itemCount);

return (
<div ref={ref}>
<OuterElementContext.Provider value={other}>
<VariableSizeList
itemData={itemData}
height={getHeight() + 2 * LISTBOX_PADDING}
width="100%"
key={itemCount}
ref={gridRef}
outerElementType={OuterElementType}
innerElementType="ul"
itemSize={(index) => getChildSize(itemData[index])}
Expand Down Expand Up @@ -89,6 +101,7 @@ function random(length) {

const useStyles = makeStyles({
listbox: {
boxSizing: 'border-box',
'& ul': {
padding: 0,
margin: 0,
Expand Down
15 changes: 14 additions & 1 deletion docs/src/pages/components/autocomplete/Virtualize.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ const OuterElementType = React.forwardRef<HTMLDivElement>((props, ref) => {
return <div ref={ref} {...props} {...outerProps} />;
});

function useResetCache(data: any) {
const ref = React.useRef<VariableSizeList>(null);
React.useEffect(() => {
if (ref.current != null) {
ref.current.resetAfterIndex(0, true);
}
}, [data]);
return ref;
}

// Adapter for react-window
const ListboxComponent = React.forwardRef<HTMLDivElement>(function ListboxComponent(props, ref) {
const { children, ...other } = props;
Expand All @@ -50,14 +60,16 @@ const ListboxComponent = React.forwardRef<HTMLDivElement>(function ListboxCompon
return itemData.map(getChildSize).reduce((a, b) => a + b, 0);
};

const gridRef = useResetCache(itemCount);

return (
<div ref={ref}>
<OuterElementContext.Provider value={other}>
<VariableSizeList
itemData={itemData}
height={getHeight() + 2 * LISTBOX_PADDING}
width="100%"
key={itemCount}
ref={gridRef}
outerElementType={OuterElementType}
innerElementType="ul"
itemSize={(index) => getChildSize(itemData[index])}
Expand All @@ -84,6 +96,7 @@ function random(length: number) {

const useStyles = makeStyles({
listbox: {
boxSizing: 'border-box',
'& ul': {
padding: 0,
margin: 0,
Expand Down