Skip to content

Conversation

@joshwooding
Copy link
Collaborator

@joshwooding joshwooding commented Aug 8, 2020

Breaking change

The abstraction hasn't proven to be used frequently enough to be valuable.

-theme.mixins.gutters(),
+paddingLeft: theme.spacing(2),
+paddingRight: theme.spacing(2),
+[theme.breakpoints.up('sm')]: {
+  paddingLeft: theme.spacing(3),
+  paddingRight: theme.spacing(3),
+},

An easy one to cross off.

Part of #20012

@joshwooding joshwooding added breaking change Introduces changes that are not backward compatible. package: core labels Aug 8, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against d5e3c71

@joshwooding joshwooding merged commit 3b8f9b0 into mui:next Aug 10, 2020
@joshwooding joshwooding deleted the remove-theme-mixins-gutters branch August 10, 2020 18:20
@oliviertassinari
Copy link
Member

@joshwooding Don't forget about the deprecation on v4 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants