-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[GridList] Rename to ImageList #22311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
What should we do with the legacy codemod? https://circleci.com/gh/mui-org/material-ui/171121?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
Member
Maybe removing the component from the test to avoid confusion? Later, we could inline the index.js we had during v4 for the tests. |
oliviertassinari
approved these changes
Aug 24, 2020
mbrookes
commented
Aug 24, 2020
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Introduces changes that are not backward compatible.
scope: image list
Changes related to the image list.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20012
GridList
Rename the
GridListcomponents toImageListto align with the current Material Design naming.