-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[ImageList] Refactor using CSS grid & React context #22395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Well, it depends on the features we need. There is a potential to make it work: https://css-tricks.com/css-grid-in-ie-debunking-common-ie-grid-misconceptions/. I have used https://autoprefixer.github.io/ in the past when doing a couple of tests with it. |
|
|
We can use https://www.npmjs.com/package/object-fit-images for the polyfilling the |
Yes, I'd found that one too. I think we'd simply document it as a pre-req for using the 5.x image list with IE11. |
packages/material-ui/src/ImageListItemBar/ImageListItemBar.test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivier Tassinari <[email protected]>
…rial-ui into imagelist-use-grid
|
My only outstanding concern is whether ImageListItemBar should be named ImageListItemTitlebar instead. The fact that the demo is called TitlebarImageList suggests that the component name is wrong. |
|
@mbrookes Anything missing to merge? I guess it comes down to, are we dropping IE 11 for the Image List component and what are the implications? |
|
Yep, just wanted to do one more pass over the migration guide to pick up the additional breaking changes, and document IE11 prereqs, then I think we're good to go. Edit: Also, as mentioned, I'm still wondering whether ImageListItemBar should be ImageListItemTitlebar instead; but perhaps it isn't important. |
Motivated by mui#22395 (comment).
Goodbye IE11?
Support:
Horizontal scrollNot included in this PR.https://material.io/components/image-lists
Preview:
https://deploy-preview-22395--material-ui.netlify.app/components/image-list/
Additional breaking changes
spacingprop togapto align with the CSS attribute.cellHeightprop torowHeight.variantprop to GridList.titlePositionprop toposition. (Note also the related classname changes.)Fix #19221