Skip to content

[Chip] Rename default variant to filled #22683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mnajdova merged 3 commits into from
Sep 22, 2020
Merged

[Chip] Rename default variant to filled #22683

mnajdova merged 3 commits into from
Sep 22, 2020
+30 −22

Conversation

@mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 21, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • [Chip] Rename default variant to filled for consistency.

    -<Chip variant="default">
+<Chip variant="filled">

Closes #18914
Part of #20012

mnajdova
mnajdova commented Sep 21, 2020
View reviewed changes
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 21, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 7019d08

@mnajdova mnajdova requested a review from mbrookes September 21, 2020 14:54
@github-actions github-actions bot mentioned this pull request Sep 21, 2020
Closed
@eps1lon
Copy link
Member

eps1lon commented Sep 21, 2020

Is filled maybe a better name for it?

I like that better. I don't really understand how I thought "standard" was better than "default" but IMO these are pretty synonymous. filled has more meaning and relates to TextField.

@mnajdova
Copy link
Member Author

mnajdova commented Sep 21, 2020

I like that better. I don't really understand how I thought "standard" was better than "default" but IMO these are pretty synonymous. filled has more meaning and relates to TextField.

done :)

joshwooding
joshwooding reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think there are references to the default variant on the docs page too so those will have to be changed as well :)

@mnajdova
Copy link
Member Author

mnajdova commented Sep 21, 2020

Looks good, I think there are references to the default variant on the docs page too so those will have to be changed as well :)

@joshwooding good catch! Fixed :)

@oliviertassinari oliviertassinari added breaking change Introduces changes that are not backward compatible. scope: chip Changes related to the chip. labels Sep 21, 2020
@mnajdova mnajdova changed the title [Chip] Rename default variant to standard [Chip] Rename default variant to filled Sep 21, 2020
@mnajdova mnajdova merged commit 079966a into mui:next Sep 22, 2020
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookes mbrookes mbrookes approved these changes

+1 more reviewer

@joshwooding joshwooding joshwooding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: chip Changes related to the chip.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Chip] variant default value

6 participants

@mnajdova @mui-pr-bot @eps1lon @mbrookes @joshwooding @oliviertassinari