Skip to content

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Sep 24, 2020

Breaking changes

  • [Rating] Move the component from the lab to the core. This component will become stable.

    -import Rating from '@material-ui/lab/Rating';
    +import Rating from '@material-ui/core/Rating';

@mbrookes mbrookes added the scope: rating Changes related to the rating. label Sep 24, 2020
@mbrookes mbrookes added this to the v5 milestone Sep 24, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 24, 2020

@material-ui/core: parsed: +1.48% , gzip: +1.69%
@material-ui/lab: parsed: +0.14% , gzip: +0.10%

Details of bundle changes

Generated by 🚫 dangerJS against 46d8079

@mbrookes mbrookes marked this pull request as ready for review September 24, 2020 22:03
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I could catch:

Capture d’écran 2020-09-25 à 01 02 01

@mbrookes
Copy link
Member Author

Oops, missed a step. So, is it a data display component, or an input component? 🤔

@oliviertassinari oliviertassinari added the breaking change Introduces changes that are not backward compatible. label Sep 25, 2020
@mbrookes
Copy link
Member Author

mbrookes commented Sep 25, 2020

@oliviertassinari
Copy link
Member

@oliviertassinari What needs to happen here?

Nothing

@mbrookes
Copy link
Member Author

mbrookes commented Sep 25, 2020

Nothing

    // The core package has no dependencies on the @material-ui/lab components.
    // We can't use ComponentsPropsList, we have to duplicate and inline the definitions.

But Rating won't be in @material-ui/lab?

@oliviertassinari
Copy link
Member

@mbrookes Oh, my bad, updated.

@mbrookes mbrookes merged commit ea36d99 into mui:next Sep 25, 2020
@mbrookes mbrookes deleted the rating-move-to-core branch September 25, 2020 20:59
@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: rating Changes related to the rating.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants