Skip to content

[Skeleton] Move from lab to core #22740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbrookes merged 3 commits into from
Sep 26, 2020
Merged

[Skeleton] Move from lab to core #22740

mbrookes merged 3 commits into from
Sep 26, 2020

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Sep 25, 2020 •
edited by oliviertassinari
Loading

Breaking changes

  • [Skeleton] Move the component from the lab to the core. This component will become stable.

    -import Skeleton from '@material-ui/lab/Skeleton';
+import Skeleton from '@material-ui/core/Skeleton';

@mbrookes mbrookes added breaking change Introduces changes that are not backward compatible. scope: skeleton Changes related to the skeleton. labels Sep 25, 2020
@mbrookes mbrookes added this to the v5 milestone Sep 25, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 25, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 25, 2020 •
edited
Loading

@material-ui/core: parsed: 0.00% 😍, gzip: +0.16%
@material-ui/lab: parsed: +0.12% , gzip: +0.20%

Details of bundle changes

Generated by 🚫 dangerJS against fff4b12

@github-actions github-actions bot mentioned this pull request Sep 25, 2020
Closed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 25, 2020
@mbrookes mbrookes marked this pull request as ready for review September 25, 2020 22:41
@mbrookes mbrookes mentioned this pull request Sep 25, 2020
Closed
@mbrookes mbrookes merged commit de5c502 into mui:next Sep 26, 2020
@Krasnopir
Copy link

Krasnopir commented Sep 28, 2020

Skeleton and Alert was moved from lab to core in 5.0.0-alpha.11
But after update i see, that Alert and Skeleton are enable from /core/ and also from /lab/

node_modules/@material-ui/lab/Skeleton
node_modules/@material-ui/core/Skeleton

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 28, 2020

@Krasnopir If you import from the lab, you will get a deprecation warning.

@oliviertassinari oliviertassinari mentioned this pull request Oct 22, 2020
Closed
42 tasks
@mbrookes mbrookes deleted the skeleton-move-to-core branch November 3, 2020 22:11
@snyk-bot snyk-bot mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: skeleton Changes related to the skeleton.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mbrookes @mui-pr-bot @Krasnopir @oliviertassinari