[core] Restrict top level imports that target CJS modules #23159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Oct 27, 2020
oliviertassinari
approved these changes
Oct 28, 2020
sujinleeme
pushed a commit
to sujinleeme/material-ui
that referenced
this pull request
Oct 29, 2020
zannager
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showcases how problematic the allowed top-level path imports are: Even we're doing it wrong.
@material-ui/system/*will pull in CommonJS modules. The special casing of "it's ok from that package but not that one" is not really viable.The current usage was not that harmful but I'll extend restricted-imports to avoid potential bigger issues in the future.