Skip to content

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Oct 23, 2020

image

Key files

Generate:

  • docs/scripts/buildApi.ts

Translations:

  • docs/translations/component-descriptions.json
  • docs/translations/prop-descriptions.json
  • docs/translations/class-descriptions.json

Example API docs:

  • docs/pages/api-docs/accordion.js
  • docs/pages/api-docs/accordion.json

Render:

  • docs/src/modules/components/ApiDocs.js

NB

The script exits early so only Accordion is updated, in order to make the PR easier to review (19 changed files rather than 400+). That will obviously need to be updated before it can be merged.

@mbrookes mbrookes added the docs Improvements or additions to the documentation. label Oct 23, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 23, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 3f6f086

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 23, 2020
@mbrookes mbrookes marked this pull request as ready for review October 23, 2020 23:40
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 24, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 26, 2020
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 15, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 15, 2020
@mbrookes mbrookes marked this pull request as ready for review November 15, 2020 15:40
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 16, 2020
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 16, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 16, 2020

I couldn't spot anything major. Browser performance seems the same, build time on Netlify seems the same. Happy to be one step closer to a similar DX as https://vuetifyjs.com/zh-Hans/api/v-avatar/.

@mbrookes mbrookes merged commit 7fbaefa into mui:next Nov 16, 2020
@mbrookes mbrookes deleted the docs-api-i18n branch November 16, 2020 21:14
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 17, 2020
@eps1lon
Copy link
Member

eps1lon commented Nov 17, 2020

Awesome stuff!

Premature celebration. Had to revert this PR (#23581) since it doesn't work when deployed with all locales. There are also some changes that I didn't see discussed so let's rewind and then replay slowly in little iterations not one big sweeping change.

oliviertassinari pushed a commit that referenced this pull request Nov 25, 2020
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request Nov 25, 2020
oliviertassinari pushed a commit to oliviertassinari/material-ui that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants