-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[docs] Improve formatting of the system #23509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve formatting of the system #23509
Conversation
11ca1bb to
e7ad1bc
Compare
mnajdova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better 👍
eps1lon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#23294 was slightly rushed.
Moving fast requires actions not words. The follow-up was announced so I have no idea what the problem is now. We're not deploying on merge anyway.
Funnily enough a 17 day open PR is considered "rushed" but your 11 hour open on is not. The "consistency" you always strive for should be applied to your own work first before demanding it of other collaborators.
The character width is not just chosen because we felt funny but because it's tied to the documentation styles. Any change should be applied to all pages. Formatting only lives from consistency.
Yeah, we had to unlock it at some point, we can't make each pull-request perfect, never going to happen nor should we aim for it, it's about the good enough. I was more interested in listing the follow-ups that can help.
There are two different use-cases:
I think that it's completely fine to have two different formating configurations for 1. and 2., the user-journey and expectations are different. It's always about how easy a developer can process the information and how can the formatting help. |
These changes help make the point that the
sxprop allows a denser vertical spacing. They don't introduce a scrollbar in the docs. They would if I had use 100 or more.#23294 was slightly rushed. I'm aware of 3 other follow-up changes that are coming:
/system/properties/