[BottomNavigation] Migrate to emotion #24556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.29% , gzip: +0.17% |
mnajdova
changed the title
mnajdova
added
the
scope: bottom navigation
queengooborg
changed the title
oliviertassinari
changed the title
oliviertassinari
approved these changes
Jan 23, 2021
oliviertassinari
force-pushed
the
migrate/BottomNavigation
branch
from
36cd56d to
e6711d4
Compare
mnajdova
reviewed
Jan 25, 2021
packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 25, 2021
packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 25, 2021
packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 25, 2021
packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 25, 2021
packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
Outdated
Show resolved
Hide resolved
mnajdova
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
BottomNavigationandBottomNavigationActioncomponents to the new emotion format as a part of #24405.Notice: there's actually quite a number of failing builds for this one, such as with the docs generation. Hoping to get some feedback on how to resolve said issues.