-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
[Menu] Migrate MenuItem to emotion #24631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@material-ui/core: parsed: +0.16% , gzip: +0.12% |
mnajdova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should implement this by adding components and componentsProps in the ListItem component, similar to how we done it in #24634 cc @oliviertassinari
|
@mnajdova On a side note, we think that we should remove MenuList > ListItem in v5 because the abstraction makes too little sense. |
In that case should we hold off with these changes until the component is refactored? |
@mnajdova I have repurposed #21587 to keep track of this effort. I don't know when it will happen. I think that it would be more valuable to first remove JSS from the list of dependencies entirely. Having to implement the |
Makes sense! @xs9627 would you like to proceed with this? #24634 should be a good template for introducing |
|
Not quite sure about the changes, just saw all tests passed for |
663d5f4 to
c0c0bad
Compare
c0c0bad to
354ff22
Compare
|
@xs9627 Thanks :) |
This PR migrates the
MenuItemcomponent to the new emotion format as a part of #24405.