[TextField] Migrate FormControlLabel to emotion #25007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
the
type: new feature
|
@material-ui/core: parsed: +0.18% , gzip: +0.07% |
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
approved these changes
Feb 21, 2021
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
@DanailH It was simpler to do the review by pushing new commits. I have tried to make them as atomic as possible, solving one problem at a time. Please review them, they should, hopefully, give insight into how the approach works. In theory, the next time you decided to migrate a component, it should go smoothly with this extra data.
eps1lon
approved these changes
Feb 21, 2021
Member
Author
|
Thank you @oliviertassinari for the changes. I did look into how the |
Member
|
@DanailH Great, doing another migration would be a good opportunity to put it in practice, hopefully, helpful for the advanced components too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took it from this list -> #24405
Seems like it wasn't picked up yet.