Skip to content

[Stepper] Migrate Stepper to emotion #25521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliviertassinari merged 8 commits into from
Mar 27, 2021
Merged

[Stepper] Migrate Stepper to emotion #25521

oliviertassinari merged 8 commits into from
Mar 27, 2021

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 27, 2021 •
edited by oliviertassinari
Loading

One chunk of #24405

@siriwatknp siriwatknp changed the title Stepper emotion migration [Stepper] migrate Stepper to emotion Mar 27, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 27, 2021 •
edited
Loading

Details of bundle changes

@material-ui/core: parsed: +0.13% , gzip: +0.05%

Generated by 🚫 dangerJS against b78f9f0

@siriwatknp siriwatknp changed the title [Stepper] migrate Stepper to emotion [Stepper] Migrate Stepper to emotion Mar 27, 2021
@siriwatknp
Copy link
Member Author

siriwatknp commented Mar 27, 2021

I got this in my local machine after run yarn test:unit. What's the fix?
image

@oliviertassinari oliviertassinari added the scope: stepper Changes related to the stepper. label Mar 27, 2021
@oliviertassinari oliviertassinari mentioned this pull request Mar 27, 2021
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 27, 2021 •
edited
Loading

I got this in my local machine after run yarn test:unit. What's the fix?

@siriwatknp I have never seen this issue before. Sebastian work on this test case. If you have a bit more details on the fail, we could ping him (not sure there is enough information to action it yet).

@oliviertassinari oliviertassinari merged commit 4ec814a into mui:next Mar 27, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 27, 2021

@siriwatknp Thanks

@siriwatknp siriwatknp deleted the stepper-emotion-migration branch March 29, 2021 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

scope: stepper Changes related to the stepper.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siriwatknp @mui-pr-bot @oliviertassinari