Skip to content

[Button] Rename pending prop to loading in LoadingButton #25874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m4theushw merged 6 commits into from
Apr 23, 2021
Merged

[Button] Rename pending prop to loading in LoadingButton #25874

m4theushw merged 6 commits into from
Apr 23, 2021

Conversation

@m4theushw
Copy link
Collaborator

@m4theushw m4theushw commented Apr 21, 2021 •
edited
Loading

Breaking change

-<LoadingButton pending pendingIndicator="Pending..." pendingPosition="end" />
+<LoadingButton loading loadingIndicator="Pending..." loadingPosition="end" />

Closes #21593
Based on #23012
Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 21, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against ade76e8

@github-actions github-actions bot mentioned this pull request Apr 21, 2021
Closed
@oliviertassinari oliviertassinari added the scope: button Changes related to the button. label Apr 21, 2021
@oliviertassinari oliviertassinari changed the title [LoadingButton] Rename pending prop to loading [Button] Rename pending prop to loading in LoadingButton Apr 21, 2021
oliviertassinari
oliviertassinari approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The least worse naming option 👌

@oliviertassinari oliviertassinari added the breaking change Introduces changes that are not backward compatible. label Apr 22, 2021
@m4theushw m4theushw merged commit ddafaa0 into mui:next Apr 23, 2021
@m4theushw m4theushw deleted the loadingButton branch April 23, 2021 17:49
@oliviertassinari oliviertassinari mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: button Changes related to the button.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Button] Change LoadingButton prop pending to loading

4 participants

@m4theushw @mui-pr-bot @oliviertassinari @guillermopincayhtm