Skip to content

[ButtonBase] Remove buttonRef prop #25896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m4theushw merged 1 commit into from
Apr 23, 2021
Merged

[ButtonBase] Remove buttonRef prop #25896

m4theushw merged 1 commit into from
Apr 23, 2021

Conversation

@m4theushw
Copy link
Collaborator

@m4theushw m4theushw commented Apr 22, 2021 •
edited by eps1lon
Loading

Part of #20012

BREAKING CHANGE

-<ButtonBase buttonRef={ref} />
+<ButtonBase ref={ref} />

-<Button buttonRef={ref} />
+<Button ref={ref} />

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 22, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against c5c0d69

@oliviertassinari oliviertassinari added breaking change Introduces changes that are not backward compatible. component: ButtonBase The React component. labels Apr 22, 2021
@m4theushw m4theushw mentioned this pull request Apr 22, 2021
Merged
1 task
@m4theushw m4theushw merged commit a05bc22 into mui:next Apr 23, 2021
@m4theushw m4theushw deleted the remove-buttonRef branch April 23, 2021 12:09
@m4theushw m4theushw mentioned this pull request Apr 23, 2021
Closed
@oliviertassinari oliviertassinari modified the milestones: v5, v5-beta Aug 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Aug 17, 2021
Closed
42 tasks
@veronikaslc veronikaslc mentioned this pull request Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: ButtonBase The React component.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

4 participants

@m4theushw @mui-pr-bot @oliviertassinari @eps1lon