[TextField] Adding the ability to call select on the TextField input

[CoreyWinkelmannPP]

I would like a similar function like focus to exist for selecting the text inside the input on the TextField component. Here is a pull request adding that in.

[oliviertassinari]

We try to remove as many imperative methods as possible.
What about using _getInputNode() for this use case and deprecating focus() and blur()?

[CoreyWinkelmannPP]

I was using _getInputNode() but in my head I was thinking that the underscore had a meaning to it. Usually I see that and think this is not a public function and could be subject to change. If this is the desire going forward than I will keep to using that method.

I do think maybe having the function getInputNode() would be a good path forward and deprecating those other functions would make sense to me.

[oliviertassinari]

I see that and think this is not a public function and could be subject to change.

You are right, but we will always try to be backward compatible with a deprecation notice before removing it.
Ideally, our unique API would be properties. However, the focus, blur and select are hard to get right.

[newoga]

My only fear with having the getInputNode() method is we're really coupling the fact a TextField component has an underlying <input /> control. Maybe there is no way around this though. I want to think about this some more.

[oliviertassinari]

@callemall/material-ui I'm fine with this PR until we have a better option for focus() and blur().
We can easily deprecate it later if needed.

[alitaheri]

@oliviertassinari We shouldn't deprecate these, these are valid use cases, we'll use warpgate later. and merging this won't introduce a breaking change later on. I'm going to merge this for now 👍

[alitaheri]

Oh shoot, we removed isMounted! I'll fix it rightaway.