Skip to content

[AutoComplete] Fix the focus / blur issue#3356

Merged
alitaheri merged 1 commit intomui:masterfrom
oliviertassinari:auto-complete-fix-focus
Feb 17, 2016
Merged

[AutoComplete] Fix the focus / blur issue#3356
alitaheri merged 1 commit intomui:masterfrom
oliviertassinari:auto-complete-fix-focus

Conversation

@oliviertassinari
Copy link
Copy Markdown
Member

@oliviertassinari
Copy link
Copy Markdown
Member Author

This is ready to be reviewed. I have made a lot of changes.

Comment thread src/auto-complete.jsx

/**
* If true, the list item is showed when a focus event triggers.
*/
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot prettier 😍 👍

@alitaheri
Copy link
Copy Markdown
Collaborator

This looks good to me. thanks a lot @oliviertassinari 👍

@oliviertassinari
Copy link
Copy Markdown
Member Author

@alitaheri This PR tooks me like 6 hours, I'm glad you like it 👍.

@newoga
Copy link
Copy Markdown
Contributor

newoga commented Feb 17, 2016

I'm really busy today but excited for this!

If you two are comfortable, feel free to move on without me 👍

@oliviertassinari
Copy link
Copy Markdown
Member Author

If you two are comfortable

I am, I have spent the all day testing it and tweaking it.

@alitaheri Feel free to merge.

@alitaheri
Copy link
Copy Markdown
Collaborator

Great job @oliviertassinari 👍 Thanks a lot for taking the time 👍 This will be appreciated by a lot of people 😍

alitaheri added a commit that referenced this pull request Feb 17, 2016
@alitaheri alitaheri merged commit 64a367c into mui:master Feb 17, 2016
@oliviertassinari oliviertassinari deleted the auto-complete-fix-focus branch February 17, 2016 20:00
@oliviertassinari
Copy link
Copy Markdown
Member Author

Awesome 🎉. There is not time to lose. That's now in production https://splitme.net/account/add 😁.

@alitaheri
Copy link
Copy Markdown
Collaborator

That was fast 😎 👍 🐎

@yongxu
Copy link
Copy Markdown
Contributor

yongxu commented Feb 18, 2016

@oliviertassinari Looks Great. Didn't see this PR before it get merged, but it is awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants