[docs] Fix CssBaseline import in example code#33614
Merged
ZeeshanTamboli merged 1 commit intomui:masterfrom Jul 22, 2022
dd-ssc:patch-1
Merged
[docs] Fix CssBaseline import in example code#33614ZeeshanTamboli merged 1 commit intomui:masterfrom dd-ssc:patch-1
CssBaseline import in example code#33614ZeeshanTamboli merged 1 commit intomui:masterfrom
dd-ssc:patch-1
Conversation
First code example on page uses
`import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';`
which fails with
`export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ... `.
Presumably, `CssBaseline` was moved recently and the first code example was not updated correspondingly; last code example on page is fine.
ZeeshanTamboli
changed the title
CssBaseline import in example code
ZeeshanTamboli
approved these changes
Jul 22, 2022
Member
ZeeshanTamboli
left a comment
ZeeshanTamboli
left a comment
There was a problem hiding this comment.
Nice catch! Thanks for the first contribution.
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
fix CssBaseline import in example code
First code example on page uses
`import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';`
which fails with
`export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ... `.
Presumably, `CssBaseline` was moved recently and the first code example was not updated correspondingly; last code example on page is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First code example on page uses
import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';which fails with
export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ....Presumably,
CssBaselinewas moved recently and the first code example was not updated correspondingly; last code example on page is fine.Preview: https://deploy-preview-33614--material-ui.netlify.app/material-ui/customization/dark-mode/#dark-mode-by-default