[AppBar] Render children before MenuElementRight#3661
Closed
halayli wants to merge 1 commit intomui:masterfrom
halayli:patch-1
Closed
[AppBar] Render children before MenuElementRight#3661halayli wants to merge 1 commit intomui:masterfrom halayli:patch-1
halayli wants to merge 1 commit intomui:masterfrom
halayli:patch-1
Conversation
Member
Author
|
On the left side, I wanted a < logo > < tabs > and on the right I wanted a < IconMenu >. In its current form, the < tabs > comes after < IconMenu > on the right. Maybe add a flag to control the order? |
Member
|
You raise a very good issue. This component needs to be more customizable.
I'm not sure that we should follow this direction. I would rather work on breaking this component into smaller bites. |
Author
|
Agreed. I like the suggestions in #773. |
Member
Closing in favour of composability. |
This was referenced Aug 19, 2021
This was referenced Sep 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{children} should render before {menuElementRight}