Skip to content

[RaisedButton] Fix label validation for 0 (number data-type) #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrdivyansh wants to merge 1 commit into from
Closed

[RaisedButton] Fix label validation for 0 (number data-type) #4285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RaisedButton/RaisedButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import EnhancedButton from '../internal/EnhancedButton';
import Paper from '../Paper';

function validateLabel(props, propName, componentName) {
if (!props.children && !props.label && !props.icon) {
if (!props.children && (!props.label && props.label !== 0) && !props.icon) {
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari May 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment than here #4284 (comment).

Copy link
Copy Markdown
Author

@mrdivyansh mrdivyansh May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment #4284 Comment

return new Error(`Required prop label or children or icon was not specified in ${componentName}.`);
}
}
Expand Down