Skip to content

[material-ui][mui-system] Cherry-pick: Add support for version runtime checks (#43190)#43233

Merged
mnajdova merged 4 commits into
mui:masterfrom
DiegoAndai:support-version-const
Aug 9, 2024
Merged

[material-ui][mui-system] Cherry-pick: Add support for version runtime checks (#43190)#43233
mnajdova merged 4 commits into
mui:masterfrom
DiegoAndai:support-version-const

Conversation

@DiegoAndai

Copy link
Copy Markdown
Member

Cherry-pick #43190 to master, so the version consts are available in v5 as well

@DiegoAndai DiegoAndai requested a review from mnajdova August 8, 2024 14:54
@DiegoAndai DiegoAndai self-assigned this Aug 8, 2024
@DiegoAndai DiegoAndai added scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI package: material-ui cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. labels Aug 8, 2024
@mui-bot

mui-bot commented Aug 8, 2024

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-43233--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ef33a9a

@DiegoAndai

DiegoAndai commented Aug 8, 2024

Copy link
Copy Markdown
Member Author

Had to do 8ac5388 refactor to solve this error (avoid this pitfall as useReactVersion also imports from utils).

I'll create a PR to do this change in next as well. I wonder why it didn't fail in #43190

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnajdova mnajdova merged commit 74ac40c into mui:master Aug 9, 2024
@DiegoAndai DiegoAndai deleted the support-version-const branch August 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants