[DatePicker] Fix calendar year child div#4344
Closed
ColadaFF wants to merge 2 commits intomui:masterfrom
Closed
Conversation
Added style to div child of the component to show all the years inside the minDate and maxDate range.
3 tasks
Member
|
@ColadaFF This breaks the vertical centering when a small range of years is set. CAn you take another look? @ToxicSalt Feel free to chip in, since you also had a PR this issue. |
Member
|
@ToxicSalt There is - you can pull from and submit a PR to their fork / branch, they then merge it, and the PR here appears as a combine contribution. However, just the sake of internet brownie points, it's probably not worth it for this PR. It might just be easier to close this, and update the title and description of #4381. |
3 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added style to div child of the component to show all the years inside the minDate and maxDate range, it set the div style to inherit the height from its parent div.
fixes mui/mui-x#7495