Skip to content

[DatePicker] Fix calendar year child div#4344

Closed
ColadaFF wants to merge 2 commits intomui:masterfrom
ColadaFF:master
Closed

[DatePicker] Fix calendar year child div#4344
ColadaFF wants to merge 2 commits intomui:masterfrom
ColadaFF:master

Conversation

@ColadaFF
Copy link
Copy Markdown

@ColadaFF ColadaFF commented May 25, 2016

Added style to div child of the component to show all the years inside the minDate and maxDate range, it set the div style to inherit the height from its parent div.

fixes mui/mui-x#7495

Added style to div child of the component to show all the years inside the minDate and maxDate range.
@mbrookes
Copy link
Copy Markdown
Member

@ColadaFF This breaks the vertical centering when a small range of years is set. CAn you take another look?

@ToxicSalt Feel free to chip in, since you also had a PR this issue.

@DylanSimowitz
Copy link
Copy Markdown

DylanSimowitz commented May 30, 2016

@mbrookes #4381 Finally a css only solution!

Also I'm kind of new to git, is there a way I can work off of someone else's PR?

@mbrookes
Copy link
Copy Markdown
Member

@ToxicSalt There is - you can pull from and submit a PR to their fork / branch, they then merge it, and the PR here appears as a combine contribution.

However, just the sake of internet brownie points, it's probably not worth it for this PR. It might just be easier to close this, and update the title and description of #4381.

@mbrookes mbrookes mentioned this pull request May 31, 2016
3 tasks
@mbrookes
Copy link
Copy Markdown
Member

mbrookes commented Jun 8, 2016

Closing in favor of #4381. @ColadaFF thanks for your contribution that is included in that PR@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DatePicker] Year overflow broken

4 participants