Skip to content

Added hover props and fixed style bug.#443

Merged
mmrtnz merged 1 commit intomui:css-in-jsfrom
mmrtnz:css-fixup
Mar 18, 2015
Merged

Added hover props and fixed style bug.#443
mmrtnz merged 1 commit intomui:css-in-jsfrom
mmrtnz:css-fixup

Conversation

@mmrtnz
Copy link
Copy Markdown
Contributor

@mmrtnz mmrtnz commented Mar 18, 2015

These changes and bugs were added/discovered as a result of refactoring toolbar.

  • Added hover prop to the following components.
    • FontIcon and SvgIcon:
      • hoverStyle: Inline-style applied when the component is being hovered.
    • DropDownMenu
      • styleIconHover: Inline-style applied to the drop down arrow icon when it is being hovered.
    • DropDownIcon
      • hoverStyle: Inline-style applied to the icon when it is being hovered.
      • Additional Props
        • iconStyle: Inline-style applied to the icon of the DropDownIcon.
        • iconClassName: CSS classname added to the icon of the DropDownIcon for additional styling.
  • Fixed style bug
    • If a specific style prop is undefined (i.e. hoverStyle) and is passed as an argument to StylePropable's mergeAndPrefix() function, it defaults to the components main style prop this.props.style. If-statements have been added where appropriate to catch this bug.

@hai-cea what are your thoughts regarding this hoverStyle prop? Should the user be responsible for handling pseudo-selectors when overriding mui component inline-styles?

mmrtnz added a commit that referenced this pull request Mar 18, 2015
Added hover props and fixed style bug.
@mmrtnz mmrtnz merged commit 4d99fae into mui:css-in-js Mar 18, 2015
@mmrtnz mmrtnz deleted the css-fixup branch March 23, 2015 14:56
@zannager zannager added the scope: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants