Added hover props and fixed style bug.#443
Merged
mmrtnz merged 1 commit intomui:css-in-jsfrom Mar 18, 2015
mmrtnz:css-fixup
Merged
Added hover props and fixed style bug.#443mmrtnz merged 1 commit intomui:css-in-jsfrom mmrtnz:css-fixup
mmrtnz merged 1 commit intomui:css-in-jsfrom
mmrtnz:css-fixup
Conversation
mmrtnz
added a commit
that referenced
this pull request
Mar 18, 2015
Added hover props and fixed style bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes and bugs were added/discovered as a result of refactoring toolbar.
hoverStyle: Inline-style applied when the component is being hovered.styleIconHover: Inline-style applied to the drop down arrow icon when it is being hovered.hoverStyle: Inline-style applied to the icon when it is being hovered.iconStyle: Inline-style applied to the icon of the DropDownIcon.iconClassName: CSS classname added to the icon of the DropDownIcon for additional styling.mergeAndPrefix()function, it defaults to the components main style propthis.props.style. If-statements have been added where appropriate to catch this bug.@hai-cea what are your thoughts regarding this hoverStyle prop? Should the user be responsible for handling pseudo-selectors when overriding mui component inline-styles?