-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[material][Badge] Replace useSlotProps with useSlot hook #45871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
commented
Apr 10, 2025
@@ -11,3 +11,12 @@ function classesTest() { | |||
|
|||
<Badge anchorOrigin={{ vertical: 'bottom' }} />; | |||
<Badge anchorOrigin={{ horizontal: 'left' }} />; | |||
<Badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test for #45867
Netlify deploy previewhttps://deploy-preview-45871--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
approved these changes
Apr 11, 2025
Thanks for working on this 👏 |
Cherry-pick PRs will be created targeting branches: v6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: badge
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
needs cherry-pick
The PR should be cherry-picked to master after merge
package: material-ui
Specific to @mui/material
v6.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usage of
useSlotProps
withuseSlot
hook and by updating component to useuseSlot
hook this issue got fixed as well.There are few other components using
useSlotProps
hook, I'll replace it withuseSlot
hook.closes #45867