-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[docs][Grid] Remove direction column
and column-reverse
from the demo
#46127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Netlify deploy previewhttps://deploy-preview-46127--material-ui.netlify.app/ Bundle size report |
Hi, could someone from the team please add the |
3712a39
to
f8c1f5a
Compare
@siriwatknp Could you please take a look at this PR when you have time? Thanks! |
f8c1f5a
to
54f9d51
Compare
Thanks for submitting the PR but I think it should be a different way. The |
54f9d51
to
4100bdb
Compare
4100bdb
to
2780b83
Compare
@siriwatknp Thanks! I've removed both column and column-reverse from the demo to avoid confusion. Let me know if anything else needs tweaking. |
column
from the demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siriwatknp @0210shivam
Should we also remove the logic and types for column
and column-reverse
? They're also in the code.
I would not go that far. Let's focus on the docs. |
Thanks for the review! Let me know if there's anything else needed before merge. |
Hi @siriwatknp @ZeeshanTamboli , just following up—thanks again for the review! |
column
from the democolumn
and column-reverse
from the demo
Merged. Thanks for the pull request. |
Thanks! |
Fixes #46110